Make virtual chunk staleness check opt out #480
Merged
+26
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomNicholas
commented
Mar 7, 2025
virtualizarr/writers/icechunk.py
Outdated
Comment on lines
332
to
335
| # Icechunk checksums currently store with second precision, so we need to make sure | ||
| # the checksum_date is at least one second in the future | ||
| timestamp_checksum = datetime.now(timezone.utc) + timedelta(seconds=1) | ||
|
|
Member
Author
There was a problem hiding this comment.
@mpiannucci I feel like this +1 second business should be in the test, rather than in the business logic?
Member
Author
There was a problem hiding this comment.
We actually came to the opposite conclusion on a call just now. The long comments in the code hopefully explain our reasoning.
for more information, see https://pre-commit.ci
Member
Author
|
The |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docs/releases.rstNew functions/methods are listed inapi.rstNew functionality has documentation