Skip to content

Conversation

maxrjones
Copy link
Member

Endiannes is indicated by specifying the 'endian' configuration of the ArrayBytesCodec named Bytes. This works on already released Zarr versions.

  • Closes #xxxx
  • Tests added
  • Tests passing
  • Full type hint coverage
  • Changes are documented in docs/releases.rst
  • New functions/methods are listed in api.rst
  • New functionality has documentation

Copy link

codecov bot commented Jun 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.44%. Comparing base (62ca069) to head (81200ba).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #640      +/-   ##
===========================================
+ Coverage    88.20%   88.44%   +0.23%     
===========================================
  Files           34       34              
  Lines         1789     1791       +2     
===========================================
+ Hits          1578     1584       +6     
+ Misses         211      207       -4     
Files with missing lines Coverage Δ
virtualizarr/codecs.py 97.95% <100.00%> (+0.08%) ⬆️
virtualizarr/manifests/utils.py 91.07% <ø> (ø)

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@maxrjones maxrjones requested a review from TomNicholas June 29, 2025 22:19
@maxrjones maxrjones added the bug Something isn't working label Jun 30, 2025
Copy link
Member

@TomNicholas TomNicholas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing!!! Let's add a release note and get this in.

@TomNicholas
Copy link
Member

(Note to readers: this means that we can release VirtualiZarr against existing versions of Zarr! #618 is only needed once zarr issues a release that includes those data types changes.)

@norlandrhagen
Copy link
Collaborator

Super cool @maxrjones! Am I remembering correctly that this unblocks NetCDF3?

@maxrjones
Copy link
Member Author

Super cool @maxrjones! Am I remembering correctly that this unblocks NetCDF3?

yep, I think so.

@maxrjones maxrjones merged commit 91362de into develop Jun 30, 2025
14 checks passed
@maxrjones maxrjones deleted the big-endian branch June 30, 2025 16:42
@maxrjones
Copy link
Member Author

darn I forgot release notes! We really need that towncrier bot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants