Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #713 +/- ##
==========================================
- Coverage 88.57% 87.47% -1.11%
==========================================
Files 34 34
Lines 1821 1820 -1
==========================================
- Hits 1613 1592 -21
- Misses 208 228 +20
🚀 New features to boost your workflow:
|
maxrjones
commented
Jul 20, 2025
Comment on lines
+145
to
+151
| # TODO: Find a more robust way to exclude any bytes codecs | ||
| # TODO: Test round-tripping big endian since that is stored in the bytes codec in V3; it should be included in data type instead for V2 | ||
| v2_codecs = [ | ||
| _to_v2_codec(get_codec_config(codec)) | ||
| for codec in v3_metadata.codecs | ||
| if codec.__class__.__name__ != "BytesCodec" | ||
| ] |
Member
Author
There was a problem hiding this comment.
@d-v-b are all ArrayBytesCodecs irrelevant for Zarr V2 where we could exclude based on whether they are a ArrayBytesCodec instance?
TomNicholas
approved these changes
Jul 21, 2025
Member
There was a problem hiding this comment.
Nice.
I do think this NISAR test should never have been merged - a unit test that downloads 0.2GB of data is ridiculous. Then we should not need any concept of slow tests. But in the interests of expediency we can wait to swap that out in a different PR, as it's not an urgent issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR applies @d-v-b's suggestion from zarr-developers/numcodecs#767 (comment) to use the filters argument in ArrayV2Metadata to store all codecs, to avoid a regression where we truncate the number of BytesBytesCodecs.
docs/releases.rstapi.rst