Skip to content

Conversation

maxrjones
Copy link
Member

Addresses #735 (comment)

  • Closes #xxxx
  • Tests added
  • Tests passing
  • Full type hint coverage
  • Changes are documented in docs/releases.rst
  • New functions/methods are listed in api.rst
  • New functionality has documentation

Copy link

codecov bot commented Jul 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.55%. Comparing base (51c9eed) to head (91d008c).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #736      +/-   ##
==========================================
+ Coverage   87.45%   87.55%   +0.09%     
==========================================
  Files          34       35       +1     
  Lines        1818     1848      +30     
==========================================
+ Hits         1590     1618      +28     
- Misses        228      230       +2     

see 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@maxrjones maxrjones added the test-upstream Run the upstream tests on this PR label Jul 25, 2025
@maxrjones maxrjones added CI Continuous Integration test-slow Run slow tests labels Jul 25, 2025
@maxrjones
Copy link
Member Author

See zarr-developers/zarr-python#3264 (comment) for an explanation of the failing upstream tests

@TomNicholas
Copy link
Member

I'm not sure why we need slow-tests at all. We already have the tests requiring a network connection specifically marked - IIUC the "slow" ones are basically those requiring a network connection which download a big file. I would prefer that we just change those tests to not download a big file. Am I missing something?

@maxrjones
Copy link
Member Author

I'm not sure why we need slow-tests at all. We already have the tests requiring a network connection specifically marked - IIUC the "slow" ones are basically those requiring a network connection which download a big file. I would prefer that we just change those tests to not download a big file. Am I missing something?

I think there's utility in end-to-end tests in addition to unit/regression tests, but we could move these outside the virtualizarr repo.

@maxrjones
Copy link
Member Author

I'll close this since we should instead work towards removing any slow tests from the repo

@maxrjones maxrjones closed this Aug 7, 2025
@TomNicholas TomNicholas deleted the ci-slow-tests branch August 8, 2025 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI Continuous Integration test-slow Run slow tests test-upstream Run the upstream tests on this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants