Skip to content

Conversation

mdsumner
Copy link
Contributor

@mdsumner mdsumner commented Sep 11, 2025

neither of 'bucket', 'path' are defined in this code

  • minor doc fix

neither of 'bucket',  'path' are defined in this code
@TomNicholas
Copy link
Member

Thanks @mdsumner . Looking at this more closely, there is a tab that displays different code for different backends. The current code with {bucket}/{path} is correct for the S3 case. Your fix with {file_url} would make it correct the Local case.

I think the correct thing to do would actually be to harmonize all the different options to all define a url variable correctly and just use that.

@mdsumner
Copy link
Contributor Author

it did seem a bit inconsistent across the backends, I appreciate it's all changed quite quickly and settling around the obstore abstraction certainly seems good. I don't care about my actual PR just I needed an example that can run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants