WIP: Add decode_timedelta
argument to open_virtual_dataset
#800
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have started an implementation here by simply following through the code and adding
decode_timedelta
whereverdecode_times
was passed along.I noticed that the type hints only allowed for
bool|None
previously, but xarray allows passing CFTime/TimedeltaCoder and per variable mappings. I have added these here to all relevant functions for now, but can revert this if I am missing the point of it only beingbool|None
.What I am missing here are additional tests. I might need a bit of help/input to make sense of what exactly we should test here.
decode_timedelta
to open_virtual_dataset #749docs/releases.rst
api.rst