-
Notifications
You must be signed in to change notification settings - Fork 54
Fix fill_value=null zarr v2 to v3 conversion for string dtypes
#845
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Fix fill_value=null zarr v2 to v3 conversion for string dtypes
#845
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #845 +/- ##
==========================================
- Coverage 89.22% 89.11% -0.12%
==========================================
Files 34 34
Lines 1987 1985 -2
==========================================
- Hits 1773 1769 -4
- Misses 214 216 +2
🚀 New features to boost your workflow:
|
|
thanks for working on this, please feel welcome to ping whenever you need a review |
|
@maxrjones and others please have a look now. I am not sure if I did the casting correctly to fix the mypy error, but all is passing now. I have also tested that my test is failing with the previous version. |
Adds support to convert unset/
nullfill values from zarr format 2 metadata to format 3 for string types.docs/releases.rst- [ ] New functions/methods are listed inapi.rst- [ ] New functionality has documentation