Skip to content

Fix typing errors #847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maxrjones merged 4 commits into from
Jan 5, 2026
Merged

Fix typing errors #847

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9234952
Fix typing errors
maxrjones Jan 5, 2026
50647ba
Merge branch 'main' into fix-typing-error
maxrjones Jan 5, 2026
b9973bb
Update virtualizarr/manifests/array.py
maxrjones Jan 5, 2026
c3c49f0
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jan 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion virtualizarr/manifests/array.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,9 @@ def __array_ufunc__(self, ufunc, method, *inputs, **kwargs) -> Any:
return _isnan(self.shape)
return NotImplemented

def __array__(self, dtype: np.typing.DTypeLike = None) -> np.ndarray:
def __array__(
self, dtype: np.typing.DTypeLike | None = None, copy: bool | None = None
) -> np.ndarray:
raise NotImplementedError(
"ManifestArrays can't be converted into numpy arrays or pandas Index objects"
)
Expand Down
11 changes: 8 additions & 3 deletions virtualizarr/manifests/array_api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,9 +97,14 @@ def concatenate(
new_shape[axis] = new_length_along_concat_axis

# do concatenation of entries in manifest
concatenated_paths = np.concatenate(
[arr.manifest._paths for arr in arrays],
axis=axis,
concatenated_paths = (
cast( # `np.concatenate` is type hinted as if the output could have Any dtype
Copy link
Member

@TomNicholas TomNicholas Jan 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I presume this is because of numpy's type promotion rules.

np.ndarray[Any, np.dtypes.StringDType],
np.concatenate(
[arr.manifest._paths for arr in arrays],
axis=axis,
),
)
)
concatenated_offsets = np.concatenate(
[arr.manifest._offsets for arr in arrays],
Expand Down
Loading