-
Notifications
You must be signed in to change notification settings - Fork 106
Add type hint checking with mypy #460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hello @dstansby! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2024-05-07 11:58:59 UTC |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #460 +/- ##
==========================================
- Coverage 99.92% 99.81% -0.12%
==========================================
Files 62 62
Lines 2692 2712 +20
==========================================
+ Hits 2690 2707 +17
- Misses 2 5 +3
|
bfd72c8 to
de0f98b
Compare
1d216e2 to
4e3fd65
Compare
|
Since this has been floating around with no objections for a while now, I propose to self-merge after #524 is merged, unless anyone objects. |
f638394 to
ce83f63
Compare
ce83f63 to
e518a56
Compare
|
@normanrz I had to fix some typing in the |
This is a starting point to work towards #443. It:
mypypre-commit-config.yamlto run the type checking usingpre-commit.mypyat least passes on the current code base.TODO: