Skip to content

Proof of concept for depending on external blosc python package #571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from
Draft

Proof of concept for depending on external blosc python package #571

Changes from 2 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
9738dde
Start work on blosc v2
dstansby Aug 26, 2024
1755c90
Add blosc dep
dstansby Aug 31, 2024
c9133ab
Replace c-blosc extension
dstansby Sep 1, 2024
dc9a0a0
Linting fixes
dstansby Apr 10, 2025
08c9f5e
Remove test that now passes
dstansby Apr 10, 2025
6eb61cf
Remove old comment
dstansby Jun 3, 2025
2a73100
Bump blosc version
dstansby Jun 3, 2025
0348723
Remove old comment
dstansby Jun 3, 2025
0f1fab5
Remove "hi"
dstansby Jul 17, 2025
da13e9a
Fix Blosc constructor
dstansby Jul 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 3 additions & 11 deletions numcodecs/blosc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,6 @@ def compress(

blosc.set_blocksize(blocksize)
if isinstance(source, np.ndarray):
print('hi')
if typesize is None:
typesize = source.dtype.itemsize
_check_not_object_array(source)
Expand Down Expand Up @@ -201,14 +200,7 @@ class Blosc(Codec):
AUTOSHUFFLE = AUTOSHUFFLE
max_buffer_size = 2**31 - 1

def __init__(
self,
cname='lz4',
clevel=5,
shuffle=SHUFFLE,
blocksize=AUTOBLOCKS,
typesize: int | None = None,
):
def __init__(self, cname='lz4', clevel=5, shuffle=SHUFFLE, blocksize=AUTOBLOCKS, typesize=None):
if isinstance(typesize, int) and typesize < 1:
raise ValueError(f"Cannot use typesize {typesize} less than 1.")
self.cname = cname
Expand All @@ -219,7 +211,7 @@ def __init__(
self.clevel = clevel
self.shuffle = shuffle
self.blocksize = blocksize
self.typesize = typesize
self._typesize = typesize

def encode(self, buf):
_check_buffer_size(buf, self.max_buffer_size)
Expand All @@ -229,7 +221,7 @@ def encode(self, buf):
clevel=self.clevel,
shuffle=self.shuffle,
blocksize=self.blocksize,
typesize=self.typesize,
typesize=self._typesize,
)

def decode(self, buf, out=None):
Expand Down
Loading