Skip to content

Conversation

@DimitriPapadopoulos
Copy link
Contributor

@DimitriPapadopoulos DimitriPapadopoulos commented Sep 22, 2024

TODO:

  • Unit tests and/or doctests in docstrings
  • Tests pass locally
  • Docstrings and API docs for any new/modified user-facing classes and functions
  • Changes documented in docs/release.rst
  • Docs build locally
  • GitHub Actions CI passes
  • Test coverage to 100% (Codecov passes)

@codecov
Copy link

codecov bot commented Sep 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.91%. Comparing base (dbc2975) to head (41b4f6c).
Report is 68 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #580      +/-   ##
==========================================
- Coverage   99.91%   99.91%   -0.01%     
==========================================
  Files          59       59              
  Lines        2334     2332       -2     
==========================================
- Hits         2332     2330       -2     
  Misses          2        2              
Files with missing lines Coverage Δ
numcodecs/compat.py 100.00% <ø> (ø)

@DimitriPapadopoulos DimitriPapadopoulos marked this pull request as ready for review September 22, 2024 20:40
@dstansby
Copy link
Contributor

Is there a ruff rule we can enable to make removing these automatic in future?

@DimitriPapadopoulos
Copy link
Contributor Author

F401 is supposed to detect such issues, and F is part of the default rulesets. However, in this specific case, ruff did not report the issue, DeepSource did.

@@ -1,9 +1,7 @@
# flake8: noqa
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# flake8: noqa

If you get rid of this line, ruff should run properly on this file. I tried it locally and it seems to work.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is handled in a different PR: #559 / 1c980e5.

I had to silence F401 and E402 in preview mode.

@dstansby dstansby merged commit 3b86d9c into zarr-developers:main Oct 9, 2024
30 checks passed
@DimitriPapadopoulos DimitriPapadopoulos deleted the PY-W2000 branch October 9, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants