Skip to content

Increase speed of Delta encoding using np.subtract #584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 10, 2024
Merged

Increase speed of Delta encoding using np.subtract #584

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9a7fe54
Use inplace subtract in Delta encoding
ehgus Sep 27, 2024
64b2bc0
ruff reformatting
ehgus Sep 27, 2024
6f408de
Add a comment explaining use of `subtract` for speed
ehgus Oct 10, 2024
61e4298
Merge branch 'main' into main
dstansby Oct 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion numcodecs/delta.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,8 @@ def encode(self, buf):
enc[0] = arr[0]

# compute differences
enc[1:] = np.diff(arr)
# using np.subtract for in-place operations
np.subtract(arr[1:], arr[0:-1], out=enc[1:])

return enc

Expand Down
Loading