Skip to content

Conversation

@DimitriPapadopoulos
Copy link
Contributor

@DimitriPapadopoulos DimitriPapadopoulos commented Oct 9, 2024

[Description of PR]

TODO:

  • Unit tests and/or doctests in docstrings
  • Tests pass locally
  • Docstrings and API docs for any new/modified user-facing classes and functions
  • Changes documented in docs/release.rst
  • Docs build locally
  • GitHub Actions CI passes
  • Test coverage to 100% (Codecov passes)

PT006 Wrong type passed to first argument of `@pytest.mark.parametrize`; expected `tuple`
PT007 Wrong values type in `@pytest.mark.parametrize` expected `list` of `tuple`
EXE001 Shebang is present but file is not executable
SIM102 Use a single `if` statement instead of nested `if` statements
SIM105 Use `contextlib.suppress(ImportError)` instead of `try`-`except`-`pass`
RSE102 Unnecessary parentheses on raised exception
@codecov
Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.91%. Comparing base (8edd3f9) to head (e7f02b7).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #594   +/-   ##
=======================================
  Coverage   99.91%   99.91%           
=======================================
  Files          59       59           
  Lines        2332     2332           
=======================================
  Hits         2330     2330           
  Misses          2        2           
Files with missing lines Coverage Δ
numcodecs/lzma.py 100.00% <100.00%> (ø)
numcodecs/registry.py 100.00% <100.00%> (ø)
numcodecs/tests/test_blosc.py 100.00% <100.00%> (ø)
numcodecs/tests/test_json.py 100.00% <ø> (ø)
numcodecs/tests/test_msgpacks.py 100.00% <ø> (ø)
numcodecs/tests/test_shuffle.py 100.00% <100.00%> (ø)

@dstansby dstansby merged commit e836f39 into zarr-developers:main Oct 9, 2024
30 checks passed
@DimitriPapadopoulos DimitriPapadopoulos deleted the ruff branch October 9, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants