Skip to content

Merge collapsible if statements #601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 15, 2024
Merged

Merge collapsible if statements #601

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 12 additions & 10 deletions numcodecs/tests/test_registry.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,15 +26,17 @@ def test_all_classes_registered():

see #346 for more info
"""
missing = set()
for _name, submod in inspect.getmembers(numcodecs, inspect.ismodule):
for _name, obj in inspect.getmembers(submod):
if inspect.isclass(obj):
if issubclass(obj, numcodecs.abc.Codec):
if obj.codec_id not in numcodecs.registry.codec_registry:
missing.add(obj.codec_id)

# remove `None``
missing.remove(None)
missing = set(
obj.codec_id
for _, submod in inspect.getmembers(numcodecs, inspect.ismodule)
for _, obj in inspect.getmembers(submod)
if (
inspect.isclass(obj)
and issubclass(obj, numcodecs.abc.Codec)
and obj.codec_id not in numcodecs.registry.codec_registry
and obj.codec_id is not None # remove `None`
)
)

if missing:
raise Exception(f"these codecs are missing: {missing}") # pragma: no cover
Loading