- 
                Notifications
    
You must be signed in to change notification settings  - Fork 106
 
Deprecate blosc helper functions #619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
b6f6461    to
    5ab921c      
    Compare
  
    | """Initialize the Blosc library environment.""" | ||
| blosc_init() | ||
| 
               | 
          ||
| init = deprecated(_init) | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess decorators don't work in .pyx files?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They probably do, but the idea here was to leave a non-deprecated version of the functions (starting with _) that we can call internally, and a deprecated version which has the same name as previous.
e1179a3    to
    b7fbea6      
    Compare
  
    
          Codecov ReportAll modified and coverable lines are covered by tests ✅ 
 Additional details and impacted files@@           Coverage Diff           @@
##             main     #619   +/-   ##
=======================================
  Coverage   99.92%   99.92%           
=======================================
  Files          62       62           
  Lines        2754     2754           
=======================================
  Hits         2752     2752           
  Misses          2        2           
 🚀 New features to boost your workflow:
  | 
    
| 
           Last call for comments - if no-one objects, I'll merge this in a couple of weeks.  | 
    
8b3cc16    to
    5f8d676      
    Compare
  
    5f8d676    to
    c2d10a5      
    Compare
  
    
As a pre-requisite for depending on pre-built
bloscwheels (see #571, #262, #464), this deprecates several functions. The idea would be to have one deprecation cycle (say numdocecs 0.14), then remove the public functions in the next release (say numcodecs 0.15).This uses the
deprecatedlibrary to handle the deprecations, which does add a nother dependency, but it is quite lightweight.