Skip to content

Conversation

@dstansby
Copy link
Contributor

I thought it would be good to get these changes out sooner rather than later, given the changes to crc32c handling are breaking. @jakirkham I expanded on the changelog entry a bit to make it clear why the change was made, and more specifically what the change was.

@dstansby dstansby requested a review from jakirkham November 18, 2024 15:40
@codecov
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.88%. Comparing base (685bfea) to head (e738e41).
Report is 34 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #650   +/-   ##
=======================================
  Coverage   99.88%   99.88%           
=======================================
  Files          62       62           
  Lines        2723     2723           
=======================================
  Hits         2720     2720           
  Misses          3        3           

@slevang
Copy link
Contributor

slevang commented Nov 18, 2024

#639 should be good to go, would be nice to get that in as well.

@jakirkham
Copy link
Member

@slevang believe the goal here is to make a simple bug fix release

We can follow up on enhancements in a subsequent release

Hope that makes sense 🙂

@dstansby
Copy link
Contributor Author

Yeah, I think we just want to get out the fix/change to crc32c here. I will take a look at #639 though, and we can do a new 0.15.0 release when that's merged.

@jakirkham jakirkham merged commit 86f5ce4 into zarr-developers:main Nov 21, 2024
25 of 26 checks passed
@jakirkham
Copy link
Member

Thanks David! 🙏

@dstansby dstansby deleted the 0141-clog branch November 21, 2024 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants