Skip to content

Conversation

@DimitriPapadopoulos
Copy link
Contributor

@DimitriPapadopoulos DimitriPapadopoulos commented Jan 14, 2025

Starting with ruff 0.9.1, rules ISC001/ISC002 are documented to be compatible with the ruff formatter, if they are both enabled. Enable them!

When using Ruff as a formatter, we recommend avoiding the following lint rules:
[...]
multi-line-implicit-string-concatenation (ISC002) if used without ISC001 and flake8-implicit-str-concat.allow-multiline = false

TODO:

  • Unit tests and/or doctests in docstrings
  • Tests pass locally
  • Docstrings and API docs for any new/modified user-facing classes and functions
  • Changes documented in docs/release.rst
  • Docs build locally
  • GitHub Actions CI passes
  • Test coverage to 100% (Codecov passes)

Starting with ruff 0.9.1, rules ISC001/ISC002 are documented to
be compatible with the ruff formatter, if they are both enabled.
Enable them!
@codecov
Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.78%. Comparing base (b8e40f7) to head (41fdb1f).
Report is 23 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #688   +/-   ##
=======================================
  Coverage   99.78%   99.78%           
=======================================
  Files          63       63           
  Lines        2754     2754           
=======================================
  Hits         2748     2748           
  Misses          6        6           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dstansby dstansby merged commit 8a0bd3b into zarr-developers:main Feb 7, 2025
25 of 26 checks passed
@DimitriPapadopoulos DimitriPapadopoulos deleted the ruff_0.9.1 branch February 7, 2025 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants