Skip to content

Unnecessary None provided as default #708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 14, 2025
Merged

Unnecessary None provided as default #708

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
de8154e
Unnecessary `None` provided as default
DimitriPapadopoulos Feb 13, 2025
4e3c467
Merge branch 'main' into PTC-W0039
d-v-b May 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions numcodecs/zarr3.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,7 +271,7 @@ def __init__(self, **codec_config: JSON) -> None:
super().__init__(**codec_config)

def evolve_from_array_spec(self, array_spec: ArraySpec) -> Shuffle:
if self.codec_config.get("elementsize", None) is None:
if self.codec_config.get("elementsize") is None:
return Shuffle(**{**self.codec_config, "elementsize": array_spec.dtype.itemsize})
return self # pragma: no cover

Expand Down Expand Up @@ -308,7 +308,7 @@ def resolve_metadata(self, chunk_spec: ArraySpec) -> ArraySpec:
return chunk_spec

def evolve_from_array_spec(self, array_spec: ArraySpec) -> FixedScaleOffset:
if self.codec_config.get("dtype", None) is None:
if self.codec_config.get("dtype") is None:
return FixedScaleOffset(**{**self.codec_config, "dtype": str(array_spec.dtype)})
return self

Expand All @@ -321,7 +321,7 @@ def __init__(self, **codec_config: JSON) -> None:
super().__init__(**codec_config)

def evolve_from_array_spec(self, array_spec: ArraySpec) -> Quantize:
if self.codec_config.get("dtype", None) is None:
if self.codec_config.get("dtype") is None:
return Quantize(**{**self.codec_config, "dtype": str(array_spec.dtype)})
return self

Expand Down Expand Up @@ -356,7 +356,7 @@ def resolve_metadata(self, chunk_spec: ArraySpec) -> ArraySpec:
return replace(chunk_spec, dtype=np.dtype(self.codec_config["encode_dtype"])) # type: ignore[arg-type]

def evolve_from_array_spec(self, array_spec: ArraySpec) -> AsType:
if self.codec_config.get("decode_dtype", None) is None:
if self.codec_config.get("decode_dtype") is None:
return AsType(**{**self.codec_config, "decode_dtype": str(array_spec.dtype)})
return self

Expand Down
Loading