In vlen, define and use const HEADER_LENGTH
#723
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously
HEADER_LENGTHwas defined invlen, but not asconst. So it could concievably be changed. While this didn't happen in practice, it does mean the compiler needs to generate code to check and use this value throughout.However
HEADER_LENGTHis intended to beconst. So define it as such. That way the compiler can generate more efficient code when using it. Further define it in terms of the type whose size it references (namelyuint32_t). Also make sure that type iscimported for referencing.Finally consistently use
HEADER_LENGTHwhen it applies throughoutvlen. PreviouslyHEADER_LENGTHwas sometimes used and in other cases the value4was used. So consistently useHEADER_LENGTHthroughout for improved code clarity. Now thatHEADER_LENGTHis markedconstthis is equally efficient.TODO: