Skip to content

Conversation

@jakirkham
Copy link
Member

@jakirkham jakirkham commented Apr 7, 2025

Fixes #724

Makes a few fixes to license metadata and packaging:

  • Switch to using SPDX metadata for license
  • Migrate to project.license-files for packaging license files
  • Include 3rd party license files
  • Drop deprecated trove-classifier for license

TODO:

  • Unit tests and/or doctests in docstrings
  • Tests pass locally
  • Docstrings and API docs for any new/modified user-facing classes and functions
  • Changes documented in docs/release.rst
  • Docs build locally
  • GitHub Actions CI passes
  • Test coverage to 100% (Codecov passes)

@codecov
Copy link

codecov bot commented Apr 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.96%. Comparing base (169db1b) to head (a26e72d).
Report is 12 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #729   +/-   ##
=======================================
  Coverage   99.96%   99.96%           
=======================================
  Files          63       63           
  Lines        2738     2738           
=======================================
  Hits         2737     2737           
  Misses          1        1           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dstansby dstansby merged commit 4f453e5 into zarr-developers:main Apr 8, 2025
30 checks passed
@jakirkham jakirkham deleted the fix_license_pkging branch April 8, 2025 08:43
@jakirkham
Copy link
Member Author

Thank you both! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Setuptools warnings (license metadata)

3 participants