Skip to content

Conversation

@jakirkham
Copy link
Member

@jakirkham jakirkham commented Apr 8, 2025

Ensure PyBytes_RESIZE is not accidentally redefined by placing it inside an #ifndef/#endif guard block.


TODO:

  • Unit tests and/or doctests in docstrings
  • Tests pass locally
  • Docstrings and API docs for any new/modified user-facing classes and functions
  • Changes documented in docs/release.rst
  • Docs build locally
  • GitHub Actions CI passes
  • Test coverage to 100% (Codecov passes)

@jakirkham jakirkham force-pushed the add_ifdef_PyBytes_RESIZE branch from 4f6a0aa to b8cbb46 Compare April 8, 2025 01:28
@codecov
Copy link

codecov bot commented Apr 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.96%. Comparing base (169db1b) to head (b8cbb46).
Report is 12 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #731   +/-   ##
=======================================
  Coverage   99.96%   99.96%           
=======================================
  Files          63       63           
  Lines        2738     2738           
=======================================
  Hits         2737     2737           
  Misses          1        1           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jakirkham jakirkham changed the title Add #ifdef guard around PyBytes_RESIZE Add #ifndef guard around PyBytes_RESIZE Apr 8, 2025
@jakirkham jakirkham closed this Apr 8, 2025
@jakirkham jakirkham deleted the add_ifdef_PyBytes_RESIZE branch April 8, 2025 02:01
@jakirkham
Copy link
Member Author

Replaced with PR: #732

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant