Skip to content

Refactor core tests, round 2 #1462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 14, 2023
Merged

Refactor core tests, round 2 #1462

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
79e86e7
chore: refactor tests to inherit create_array from a base class
d-v-b Jul 14, 2023
f7e1461
chore: widen type of shape to variable length tuple
d-v-b Jul 14, 2023
ff2e5ea
chore: add importskip barrier for lmdb
d-v-b Jul 14, 2023
e449f3c
docs: release notes
d-v-b Jul 14, 2023
80e6079
chore: remove fsstore kwargs variable
d-v-b Jul 14, 2023
a1cb970
chore: fix type error in creation of fsstore
d-v-b Jul 14, 2023
9d5b41f
chore: add `create_filters` method to TestArray. Pop out `compressor`…
d-v-b Jul 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions docs/release.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,12 @@ Enhancements
* **Block Indexing**: Implemented blockwise (chunk blocks) indexing to ``zarr.Array``.
By :user:`Altay Sansal <tasansal>` :issue:`1428`

Maintenance
~~~~~~~~~~~

* Refactor the core array tests to reduce code duplication.
By :user:`Davis Bennett <d-v-b>` :issue:`1462`.

.. _release_2.15.0:

2.15.0
Expand Down
2 changes: 1 addition & 1 deletion zarr/storage.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,7 +300,7 @@ def _require_parent_group(

def init_array(
store: StoreLike,
shape: Tuple[int, ...],
shape: Union[int, Tuple[int, ...]],
chunks: Union[bool, int, Tuple[int, ...]] = True,
dtype=None,
compressor="default",
Expand Down
Loading