Skip to content

fix: array creation prototype #2306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 7, 2024
Merged

fix: array creation prototype #2306

merged 1 commit into from
Oct 7, 2024

Conversation

@jhamman
Copy link
Member

@jhamman jhamman commented Oct 7, 2024 •
edited
Loading

This changes the prototype keyword to data in the Group.foo_like methods, matching the keyword name in 2.x.

Supports dask/dask#11388, followup to #2210
TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/tutorial.rst
  • Changes documented in docs/release.rst
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

@jhamman jhamman merged commit 1674282 into zarr-developers:v3 Oct 7, 2024
20 checks passed
@jhamman jhamman deleted the fix/dask-compat-prototype branch October 7, 2024 17:37
@jhamman jhamman added the V3 label Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TomAugspurger TomAugspurger TomAugspurger approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jhamman @TomAugspurger