Skip to content

Conversation

jhamman
Copy link
Member

@jhamman jhamman commented Oct 13, 2024

Run's CI on support branch. Wait to merge until after #2345 is settled.

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/tutorial.rst
  • Changes documented in docs/release.rst
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

on:
push:
branches: [ main ]
branches: [ main, support/2.x ]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
branches: [ main, support/2.x ]
branches: [ support/v2]

I think we don't want this triggering on main (which will have its own GH actions files?)

Copy link
Contributor

@dstansby dstansby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 , but I think we can get rid of main here?

@jhamman jhamman requested a review from dstansby October 13, 2024 13:18
@dstansby
Copy link
Contributor

I'm not sure what order this needs to be merged in, so feel free to self merge @jhamman

@jhamman jhamman merged commit ba1daa3 into zarr-developers:support/v2 Oct 13, 2024
16 checks passed
@jhamman jhamman deleted the ci/run-ci-on-support-branch branch October 13, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants