Skip to content

handle empty string prefix in zipstore delete dir #2492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 15, 2024
Merged

handle empty string prefix in zipstore delete dir #2492

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
22bf720
handle empty string prefix in zipstore delete dir
d-v-b Nov 15, 2024
a1b6da9
Merge branch 'main' into fix/zipstore-delete-dir
d-v-b Nov 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/zarr/storage/zip.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,7 @@ async def set_if_not_exists(self, key: str, value: Buffer) -> None:
async def delete_dir(self, prefix: str) -> None:
# only raise NotImplementedError if any keys are found
self._check_writable()
if not prefix.endswith("/"):
if prefix != "" and not prefix.endswith("/"):
prefix += "/"
async for _ in self.list_prefix(prefix):
raise NotImplementedError
Expand Down