Skip to content

Apply ruff preview rule RUF036 #2524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 12, 2024
Merged

Apply ruff preview rule RUF036 #2524

merged 1 commit into from
Dec 12, 2024

Conversation

@DimitriPapadopoulos
Copy link
Contributor

@DimitriPapadopoulos DimitriPapadopoulos commented Dec 1, 2024 •
edited
Loading

The None literal represents the absence of a value. For readability, it's preferred to write the more informative type expressions first.

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/tutorial.rst
  • Changes documented in docs/release.rst
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

@dcherian dcherian enabled auto-merge (squash) December 12, 2024 03:59
@DimitriPapadopoulos
Apply ruff preview rule RUF036
41f6fe1 
RUF036 `None` not at the end of the type annotation.

The `None` literal represents the absence of a value. For readability,
it's preferred to write the more informative type expressions first.
auto-merge was automatically disabled December 12, 2024 07:26

Head branch was pushed to by a user without write access

@d-v-b d-v-b merged commit 4e53a70 into zarr-developers:main Dec 12, 2024
27 checks passed
@DimitriPapadopoulos DimitriPapadopoulos deleted the RUF036 branch December 12, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dcherian dcherian dcherian approved these changes

@d-v-b d-v-b d-v-b approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@DimitriPapadopoulos @dcherian @d-v-b