Skip to content

Conversation

@jhamman
Copy link
Member

@jhamman jhamman commented Dec 5, 2024

This PR makes a few minor changes to our project dependencies and test imports.

closes #2391
Fixes #735
Supersedes #2395

@jhamman jhamman requested a review from d-v-b December 5, 2024 05:23
Copy link
Contributor

@dstansby dstansby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a big change in user facing behaviour when the package is installed, so should definitely have a prominent entry in the what's new/changed for 3.0 docs!

This probably also needs a change to the installation docs to explain how to install packages for remote data access.

@jhamman
Copy link
Member Author

jhamman commented Dec 5, 2024

This is a big change in user facing behaviour when the package is installed, so should definitely have a prominent entry in the what's new/changed for 3.0 docs!

This is not quite right. Fsspec is an optional dependency for Zarr-Python 2 as well. I'm planning to do a rev on the docs next week so will include this then.

@dstansby
Copy link
Contributor

dstansby commented Dec 5, 2024

This is not quite right. Fsspec is an optional dependency for Zarr-Python 2 as well. I'm planning to do a rev on the docs next week so will include this then.

Ah my bad. I think it's still worth adding a quick changelog note somewhere that this is a change in behaviour from the current beta release - shouldn't take much time to add, and I think adds a lot of value for users if we have a user-facing log of changes like these, even if from beta to beta to release.

@jhamman jhamman enabled auto-merge (squash) December 6, 2024 04:29
@jhamman jhamman requested a review from dstansby December 6, 2024 04:30
Copy link
Contributor

@dstansby dstansby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks!

@jhamman jhamman merged commit 0cca6b0 into zarr-developers:main Dec 6, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rethinking Zarr's core dependencies Update fsspec minimal version?

3 participants