Skip to content

rename exists_ok to overwrite #2548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 12, 2024
Merged

rename exists_ok to overwrite #2548

merged 2 commits into from
Dec 12, 2024

Conversation

@d-v-b
Copy link
Contributor

@d-v-b d-v-b commented Dec 10, 2024

exists_ok is renamed to overwrite. closes #2527

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/tutorial.rst
  • Changes documented in docs/release.rst
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

@d-v-b
Copy link
Contributor Author

d-v-b commented Dec 12, 2024

any objections to me self-merging this shortly?

@dcherian dcherian merged commit 01b73a7 into main Dec 12, 2024
32 checks passed
@keewis keewis mentioned this pull request Dec 13, 2024
Closed
@jhamman jhamman deleted the refactor/exists-ok-to-overwrite branch January 4, 2025 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jhamman jhamman jhamman approved these changes

@dcherian dcherian dcherian approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Rename exists_ok to overwrite

4 participants

@d-v-b @jhamman @dcherian