Skip to content

Conversation

dstansby
Copy link
Contributor

I pinned numpy in a previous PR because it was breaking tests 😭 . This un-pins it to see what's going wrong, and then hopefully fix it.

@dstansby dstansby added the V2 Affects the v2 branch label Dec 11, 2024
@dstansby dstansby added this to the 2.18.4 milestone Dec 11, 2024
@d-v-b
Copy link
Contributor

d-v-b commented Dec 11, 2024

numpy 2.2 changes the string repr for arrays (shape info is now displayed), maybe that's the culprit?

@dstansby
Copy link
Contributor Author

From memory that's exactly it

@dcherian
Copy link
Contributor

If you have the env, then running pytest-accept should quickly fix it

@dstansby
Copy link
Contributor Author

Ah amazing, thanks for sharing! https://github.com/scientific-python/pytest-doctestplus does a similar thing, but I'll checkout pytest-accept too

Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.95%. Comparing base (10a4629) to head (6c455ed).
Report is 11 commits behind head on support/v2.

Additional details and impacted files
@@             Coverage Diff             @@
##           support/v2    #2552   +/-   ##
===========================================
  Coverage       99.95%   99.95%           
===========================================
  Files              38       38           
  Lines           14664    14666    +2     
===========================================
+ Hits            14658    14660    +2     
  Misses              6        6           
Files with missing lines Coverage Δ
zarr/convenience.py 100.00% <100.00%> (ø)
zarr/core.py 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dstansby dstansby marked this pull request as ready for review December 12, 2024 14:32
@d-v-b d-v-b merged commit b16b743 into support/v2 Dec 12, 2024
18 checks passed
@d-v-b d-v-b deleted the unpin-numpy branch December 12, 2024 15:22
@dstansby dstansby mentioned this pull request Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

V2 Affects the v2 branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants