Clean up zarr.core.metadata API
#2642
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dstansby
changed the title
zarr.core.codecs apizarr.core.metadata api
dstansby
changed the title
zarr.core.metadata apizarr.core.metadata API
|
👍 doesn't need to block 3.0.0, and needs updating, but would be good to keep it open to remind me to update it at some point |
dstansby
added
the
needs release notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to other sub-modules in
zarr.core,zarr.core.metadataimports some stuff into it's top level namespace. To stay consistent, I've:DataTypehere, because it's used in the code reprs.zarr.core.metadata.{common, v2, v3}privateAn alternative here would be to keep
zarr.core.metadata.{common, v2, v3}, and move the documentation of classes currently defined in zarr.core.codecs back to their submodules. Thoughts?