Skip to content

Make botocore an optional test dependency #2768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 28, 2025
Merged

Make botocore an optional test dependency #2768

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
630829e
Make botocore an optional test dependency
dstansby Jan 26, 2025
d524094
Add release notes
dstansby Jan 28, 2025
ed5acf8
Merge branch 'main' into botocore-test-dep
jhamman Jan 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,10 +73,12 @@ test = [
"coverage",
"pytest",
"pytest-cov",
'zarr[remote]',
"botocore",
"s3fs",
"moto[s3,server]",
"pytest-asyncio",
"pytest-accept",
"moto[s3,server]",
"requests",
"rich",
"mypy",
Expand Down
4 changes: 2 additions & 2 deletions tests/test_store/test_fsspec.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
from typing import TYPE_CHECKING

import pytest
from botocore.session import Session
from packaging.version import parse as parse_version

import zarr.api.asynchronous
Expand All @@ -26,6 +25,7 @@
requests = pytest.importorskip("requests")
moto_server = pytest.importorskip("moto.moto_server.threaded_moto_server")
moto = pytest.importorskip("moto")
botocore = pytest.importorskip("botocore")

# ### amended from s3fs ### #
test_bucket_name = "test"
Expand All @@ -52,7 +52,7 @@ def s3_base() -> Generator[None, None, None]:

def get_boto3_client() -> botocore.client.BaseClient:
# NB: we use the sync botocore client for setup
session = Session()
session = botocore.session.Session()
return session.create_client("s3", endpoint_url=endpoint_url)


Expand Down
Loading