Pluralize glob and file in labeler.yml #2785
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Naturally, perms are an issue. 🤦 |
|
OK, the good news is that with the .rst added, this thing does, in fact, work. I will now revert to pull_request_target (which will fail for the above permissions issues). |
|
Thanks @moradology for the quick fix here. |
moradology
force-pushed
the
fix/get-labeler-right
branch
from
123fc21 to
88ef0dd
Compare
|
OK, the fix should be ready to go in and it should Just Work™ |
jhamman
approved these changes
Jan 31, 2025
|
We'll give it a try! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Well, this is embarrassing. Need to pluralize
globandfilewhen usingallas opposed toany. Makes sense. Missed it. Going to test things first by changing target topull_requestrather thanpull_request_targetTODO:
docs/user-guide/*.rstchanges/