Skip to content

Enable stateful tests for ZipStore #2803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Enable stateful tests for ZipStore #2803

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ea1356e
Enable stateful tests for ZipStore
dcherian Feb 6, 2025
99d9e52
Merge branch 'main' into update-stateful-tests
dcherian Jun 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions tests/test_store/test_stateful.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
)

from zarr.abc.store import Store
from zarr.storage import LocalStore, ZipStore
from zarr.storage import LocalStore
from zarr.testing.stateful import ZarrHierarchyStateMachine, ZarrStoreStateMachine

pytestmark = [
Expand All @@ -19,19 +19,13 @@ def test_zarr_hierarchy(sync_store: Store):
def mk_test_instance_sync() -> ZarrHierarchyStateMachine:
return ZarrHierarchyStateMachine(sync_store)

if isinstance(sync_store, ZipStore):
pytest.skip(reason="ZipStore does not support delete")

run_state_machine_as_test(mk_test_instance_sync)


def test_zarr_store(sync_store: Store) -> None:
def mk_test_instance_sync() -> None:
return ZarrStoreStateMachine(sync_store)

if isinstance(sync_store, ZipStore):
pytest.skip(reason="ZipStore does not support delete")

if isinstance(sync_store, LocalStore):
# This test uses arbitrary keys, which are passed to `set` and `delete`.
# It assumes that `set` and `delete` are the only two operations that modify state.
Expand Down
Loading