Strengthen pickling test and fix ZipStore __getstate__() #2807
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs release notes
maxrjones
commented
Feb 6, 2025
maxrjones
changed the title
github-actions
bot
removed
the
needs release notes
maxrjones
changed the title
jhamman
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's important for stores that manually implement
__getstate__and__setstate__that the store behavior is tested beyond a simply equality check. This is motivated by #1661, where I first added incorrect serialization functionality even though it passed this test. This PR adds a simple set/get check on the serialization test and exposes an issue with ZipStore.TODO:
docs/user-guide/*.rstchanges/