Skip to content

Implement soft delete for zip store #2838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Implement soft delete for zip store #2838

wants to merge 2 commits into from

Conversation

@asimchoudhary
Copy link
Contributor

@asimchoudhary asimchoudhary commented Feb 15, 2025 •
edited
Loading

[Description of PR]
fixes: #828
TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/user-guide/*.rst
  • Changes documented as a new file in changes/
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

@github-actions github-actions bot added the needs release notes Automatically applied to PRs which haven't added release notes label Feb 15, 2025
@d-v-b
Copy link
Contributor

d-v-b commented Feb 24, 2025

@jhamman thoughts on this approach?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

needs release notes Automatically applied to PRs which haven't added release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Implementing ZipStore's __delitem__ via overwrite

2 participants

@asimchoudhary @d-v-b