Skip to content

Fix hatch matrix setup for minimal and optional dependencies #2872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Apr 16, 2025
Merged

Fix hatch matrix setup for minimal and optional dependencies #2872

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
7976bd8
Run minimal tests without fsspec, requests, aiohttp
maxrjones Feb 27, 2025
11b2c78
Retain existing test env names
maxrjones Feb 28, 2025
b2442ba
Use importorskip
maxrjones Feb 28, 2025
5320edc
Merge branch 'main' into minimal-tests
maxrjones Feb 28, 2025
9dc1845
Specify which matrix config to upload codecov on
maxrjones Feb 28, 2025
39fff00
Merge branch 'main' into minimal-tests
maxrjones Apr 11, 2025
ec880dd
Remove redundant gpu env
maxrjones Apr 12, 2025
f5c3990
Add obstore to min_deps definition
maxrjones Apr 12, 2025
1364fb9
Fix optional dependency set
maxrjones Apr 12, 2025
0a266d8
Add remote_tests set to doctest
maxrjones Apr 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 12 additions & 8 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,20 +72,25 @@ gpu = [
test = [
"coverage",
"pytest",
"pytest-asyncio",
"pytest-cov",
"pytest-accept",
"rich",
"mypy",
"hypothesis",
]
remote_tests = [
'zarr[remote]',
'zarr[optional]',
"botocore",
"s3fs",
"moto[s3,server]",
"pytest-asyncio",
"pytest-accept",
"requests",
]
optional = [
"rich",
"mypy",
"hypothesis",
"universal-pathlib",
"universal_pathlib"
]
optional = ["rich", "universal-pathlib"]
docs = [
# Doc building
'sphinx==8.1.3',
Expand Down Expand Up @@ -134,7 +139,6 @@ build.hooks.vcs.version-file = "src/zarr/_version.py"
[tool.hatch.envs.test]
dependencies = [
"numpy~={matrix:numpy}",
"universal_pathlib",
]
features = ["test"]

Expand All @@ -146,7 +150,7 @@ version = ["minimal"]
[[tool.hatch.envs.test.matrix]]
python = ["3.11", "3.12", "3.13"]
numpy = ["1.25", "2.1"]
features = ["optional"]
features = ["remote_tests"]

[[tool.hatch.envs.test.matrix]]
python = ["3.11", "3.12", "3.13"]
Expand Down
3 changes: 3 additions & 0 deletions tests/test_store/test_core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import importlib
import tempfile
from pathlib import Path

Expand Down Expand Up @@ -119,6 +120,8 @@ async def test_make_store_path_invalid() -> None:
await make_store_path(1) # type: ignore[arg-type]


@pytest.mark.skipif(not importlib.util.find_spec("requests"), reason="requires requests")
@pytest.mark.skipif(not importlib.util.find_spec("aiohttp"), reason="requires aiohttp")
async def test_make_store_path_fsspec(monkeypatch) -> None:
pytest.importorskip("fsspec")
store_path = await make_store_path("http://foo.com/bar")
Expand Down
Loading