Skip to content

Fix ABSStore w/ latest azure-blob-client on v2 #2887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 4, 2025
Merged

Fix ABSStore w/ latest azure-blob-client on v2 #2887

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d83cebc
Try and fix ABSStore on v2
dstansby Mar 4, 2025
4d41e0e
Merge branch 'support/v2' into fix-abstore
dstansby Mar 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions requirements_dev_optional.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,7 @@ lmdb==1.6.2; sys_platform != 'win32'
# optional library requirements for Jupyter
ipytree==0.2.2
ipywidgets==8.1.5
# optional library requirements for services
# don't let pyup change pinning for azure-storage-blob, need to pin to older
# version to get compatibility with azure storage emulator on appveyor (FIXME)
azure-storage-blob==12.21.0 # pyup: ignore
azure-storage-blob==12.24.1
redis==5.2.1
types-redis
types-setuptools
Expand Down
2 changes: 1 addition & 1 deletion zarr/_storage/absstore.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,7 @@ def getsize(self, path=None):
elif not fs_path.endswith("/"):
fs_path += "/"
for blob in self.client.walk_blobs(name_starts_with=fs_path, delimiter="/"):
blob_client = self.client.get_blob_client(blob)
blob_client = self.client.get_blob_client(blob.name)
if blob_client.exists():
size += blob_client.get_blob_properties().size
return size
Expand Down
Loading