-
-
Couldn't load subscription status.
- Fork 365
(fix): use typesize on Blosc codec
#2962
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
dstansby
merged 22 commits into
zarr-developers:main
from
ilan-gold:ig/typesize_for_blosc
May 8, 2025
Merged
Changes from 18 commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
0c45340
(fix): use `typesize` on `Blosc` codec
ilan-gold 3074bf2
(chore): relnote
ilan-gold 386f09f
(fix): intersphinx
ilan-gold e7c5b00
(fix): look at that compression ratio!
ilan-gold 5e1a593
(fix): add test
ilan-gold eb6f173
Merge branch 'main' into ig/typesize_for_blosc
ilan-gold 9fe74b8
(fix): min version
ilan-gold 927a2bc
Merge branch 'ig/typesize_for_blosc' of github.com:ilan-gold/zarr-pyt…
ilan-gold 6f0feca
(fix): parenthesis?
ilan-gold 25ece76
(fix): try assertion error
ilan-gold 7bf71b4
(fix): windows size
ilan-gold 4ac85bb
Merge branch 'main' into ig/typesize_for_blosc
ilan-gold 3c9c6cc
(fix): add bytes print
ilan-gold d4daa79
Merge branch 'ig/typesize_for_blosc' of github.com:ilan-gold/zarr-pyt…
ilan-gold 03f298a
Merge branch 'main' into ig/typesize_for_blosc
dstansby 45693bf
(fix): aghh windows latest is correct, error for non latest
ilan-gold 21950a2
Merge branch 'ig/typesize_for_blosc' of github.com:ilan-gold/zarr-pyt…
ilan-gold 0fcc9f0
(fix): conditions for sizes
ilan-gold fa7092f
(fix): try clearer data
ilan-gold 5cfa80f
(fix): awesome!
ilan-gold e5653f4
(fix): pre-commit
ilan-gold 3a6895e
Merge branch 'main' into ig/typesize_for_blosc
dstansby File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| Internally use `typesize` constructor parameter for :class:`numcodecs.blosc.Blosc` to improve compression ratios back to the v2-package levels. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a thought, worth explicitly specifying the data type (and making the data smaller)? Don't know if it will fix the windows issue, but I think worth doing anyway os there's a concrete bytesize, and perhaps using integer data type will help with linux/windows because perhaps they have different floating point implementations (although that's wild speculation on my part...)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
arangeis defaultuint64so I'll push something with that added.