Fix typing errors in testing.stateful #3045
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
needs release notes
dcherian
reviewed
May 7, 2025
dcherian
reviewed
May 7, 2025
dstansby
force-pushed
the
typing-errors-stateful
branch
from
aa52782 to
0161c61
Compare
dstansby
force-pushed
the
typing-errors-stateful
branch
from
0161c61 to
27f41c3
Compare
dcherian
approved these changes
May 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes typing errors in the stateful testing sub-module.
Along the way I also realised that the dimension names parameter was typed wrong - it should allow None to be in the list too. So I made a type variable for that, and fixed the typing throughout.