Don't warn when order passed for v2 arrays #3078
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs release notes
dstansby
force-pushed
the
v2-no-order-warn
branch
2 times, most recently
from
48c5702 to
2f87e95
Compare
dstansby
force-pushed
the
v2-no-order-warn
branch
from
2f87e95 to
b226526
Compare
dstansby
force-pushed
the
v2-no-order-warn
branch
from
8e430a1 to
33f1b81
Compare
|
I'm going to work on this in a fresh PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The correct warning is raised further down the call stack in
AsyncArray._create, so no need for it increate().Edit: this is turning into a bit of a "fix all the order arguments" rabbit hole...
Fixes #2948