Skip to content

(feat): use np.zeros for buffer creation with fill_value=0 #3082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 23, 2025
Merged

(feat): use np.zeros for buffer creation with fill_value=0 #3082

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9eac892
(feat): use `np.zeros` for buffer creation when possible
ilan-gold May 22, 2025
29508cf
(fix): add comment and check
ilan-gold May 22, 2025
b0f815f
(chore): relnote
ilan-gold May 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/zarr/core/buffer/cpu.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@
order: Literal["C", "F"] = "C",
fill_value: Any | None = None,
) -> Self:
if fill_value is None:
if fill_value is None or fill_value == 0:

Check warning on line 157 in src/zarr/core/buffer/cpu.py

View check run for this annotation

Codecov / codecov/patch

src/zarr/core/buffer/cpu.py#L157 

Added line #L157 was not covered by tests
return cls(np.zeros(shape=tuple(shape), dtype=dtype, order=order))
else:
return cls(np.full(shape=tuple(shape), fill_value=fill_value, dtype=dtype, order=order))
Expand Down
Loading