-
-
Notifications
You must be signed in to change notification settings - Fork 363
Use mkdocs-material for Zarr-Python documentation #3118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I love the way this looks! Thanks so much for working on this. |
Apologies, I thought I had 👍'd previously. Now doing that retroactively in a general sense of the move and specifically for the style & the use of markdown. But I agree that we need a careful review of the pages (and personally, I liked the cards on the landing page) |
Thanks a lot for working on this, @maxrjones! I love the switch from
I'm with Josh on this one. Can we also add cards in mk-docs? |
While I prefer the no-cards version, I also believe it's preferable to decide based on the ease of use for people who aren't extremely familiar with the Zarr-Python documentation, because those people may be completely blocked or dissuaded from using the library whereas others will likely find their way anyways. I could do some polling on preferences if others agree with this philosophy. I also think that the transition to mkdocs shouldn't be blocked by whether the home page has cards. If people think this'll take a while to decide on, I could add this style card for now to minimize the stylistic decisions included in this PR. |
I just spent some time here and wanted to give a big 👍 to the switch to mkdocs-material. I wanted to do this leading up to 3.0 but choose not to in order to avoid scope creep in the documentation update. As for cards, I don't think this should bend the decision here either way. We should optimize for usability. If users can quickly find their way to the main sections of the docs, then I'm for dropping the cards. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3118 +/- ##
=======================================
Coverage 61.21% 61.21%
=======================================
Files 84 84
Lines 9923 9923
=======================================
Hits 6074 6074
Misses 3849 3849
🚀 New features to boost your workflow:
|
A status update:
I appreciate all the high-level feedback on the switch. Thank you @ianhi in particular for discussing this PR the Zarr dev meeting and for summarizing your perspective on sphinx vs mkdocs above. I'm actually about to head out for a vacation until Monday, so if you or anyone else wants to use the completed rst->md conversion with a sphinx/myst based setup it'd be a good time to do so. It might be obvious that I prefer mkdocs over sphinx, but I respect that each have their strengths. Mostly, I just find the current API documentation really hard to use and want something better. I'm willing to spend the time on this massive update, but if someone else wants to finish the work using sphinx I certainly wouldn't complain 😉 |
@zarr-developers/python-core-devs this PR is now ready for review. I recommend reviewing it without striving for perfection because many people share the opinion that the current documentation is difficult to use, merging would allow other people to also contribute to the docs improvements, and each additional merge commit increases the chances of new mistakes creeping in. Thanks for your consideration! |
thank you @maxrjones! |
This PR switches the docs from sphinx to mkdocs-material (closes #2894)
Preview: https://zarr--3118.org.readthedocs.build/en/3118/
Motivation for using mkdocs-material
Changes
Apart from the conversion to markdown and configuration updates, I made the following changes:
Acknowledgments
Claude assisted with this PR
TODO
changes/