Skip to content

Conversation

d-v-b
Copy link
Contributor

@d-v-b d-v-b commented Jun 18, 2025

There's a windows-specific issue where np.dtype('i') is an instance of np.dtypes.IntDType instead of np.dtypes.Int32DType, which breaks dtype inference. This PR adds logic to the dtype inference for Int32 to handle this case, and adds a test that fails without that fix.

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/user-guide/*.rst
  • Changes documented as a new file in changes/
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

@github-actions github-actions bot added the needs release notes Automatically applied to PRs which haven't added release notes label Jun 18, 2025
@github-actions github-actions bot removed the needs release notes Automatically applied to PRs which haven't added release notes label Jun 18, 2025
@d-v-b d-v-b requested a review from dstansby June 19, 2025 09:12
@dstansby dstansby added this to the 3.1.0 milestone Jun 19, 2025
@d-v-b d-v-b requested a review from TomAugspurger June 24, 2025 19:34
@d-v-b d-v-b requested a review from jhamman June 26, 2025 09:07
@d-v-b
Copy link
Contributor Author

d-v-b commented Jun 26, 2025

rtd build is failing but I can't replicate this locally...

@jhamman
Copy link
Member

jhamman commented Jun 28, 2025

docs should be fixed now. Thanks @d-v-b

@d-v-b d-v-b merged commit baabf08 into zarr-developers:main Jun 30, 2025
28 checks passed
Copy link

codecov bot commented Sep 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.48%. Comparing base (bbdefac) to head (dacc079).
⚠️ Report is 130 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3151   +/-   ##
=======================================
  Coverage   94.47%   94.48%           
=======================================
  Files          78       78           
  Lines        8604     8607    +3     
=======================================
+ Hits         8129     8132    +3     
  Misses        475      475           
Files with missing lines Coverage Δ
src/zarr/core/dtype/npy/int.py 98.73% <100.00%> (+0.01%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants