Skip to content

Fix mypy 1.16 errors #3158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 7, 2025
Merged

Fix mypy 1.16 errors #3158

merged 2 commits into from
Jul 7, 2025

Conversation

DimitriPapadopoulos
Copy link
Contributor

@DimitriPapadopoulos DimitriPapadopoulos commented Jun 19, 2025 •
edited
Loading

Start fixing mypy 1.16 errors.

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/user-guide/*.rst
  • Changes documented as a new file in changes/
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

@github-actions github-actions bot added the needs release notes Automatically applied to PRs which haven't added release notes label Jun 19, 2025
@DimitriPapadopoulos DimitriPapadopoulos force-pushed the mypy branch 2 times, most recently from 65ffd01 to 1d0d247 Compare June 19, 2025 18:56
@DimitriPapadopoulos DimitriPapadopoulos changed the title Fix mypy 1.16 errors Fix mypy 0.16 errors Jun 19, 2025
@DimitriPapadopoulos DimitriPapadopoulos changed the title Fix mypy 0.16 errors Fix mypy 1.16 errors Jun 19, 2025
@DimitriPapadopoulos DimitriPapadopoulos marked this pull request as ready for review June 19, 2025 19:05
dstansby
dstansby suggested changes Jun 20, 2025
View reviewed changes
Copy link
Contributor

@dstansby dstansby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of these fixes are in #3133 - we should wait until that's merged for this.

@DimitriPapadopoulos DimitriPapadopoulos marked this pull request as draft June 20, 2025 09:02
@DimitriPapadopoulos
Fix mypy error
08138e0 
error: Module "zarr" has no attribute "blosc"  [attr-defined]
@dstansby dstansby marked this pull request as ready for review July 6, 2025 20:11
@dstansby
Copy link
Contributor

dstansby commented Jul 6, 2025

Is this good to go?

@DimitriPapadopoulos
Copy link
Contributor Author

DimitriPapadopoulos commented Jul 7, 2025 •
edited
Loading

Yes, I think so. It looks like zarr.blosc is not defined any more, so the benchmark needs to include blosc directly.

@dstansby dstansby enabled auto-merge (squash) July 7, 2025 11:02
@dstansby dstansby merged commit a07c660 into zarr-developers:main Jul 7, 2025
30 checks passed
@DimitriPapadopoulos DimitriPapadopoulos deleted the mypy branch July 7, 2025 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@dstansby dstansby dstansby approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs release notes Automatically applied to PRs which haven't added release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@DimitriPapadopoulos @dstansby