Skip to content

Appending to dictionary following its definition #3159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 20, 2025
Merged

Appending to dictionary following its definition #3159

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/zarr/core/dtype/npy/structured.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,8 +162,10 @@
[f_name, f_dtype.to_json(zarr_format=zarr_format)] # type: ignore[list-item]
for f_name, f_dtype in self.fields
]
base_dict = {"name": self._zarr_v3_name}
base_dict["configuration"] = {"fields": fields} # type: ignore[assignment]
base_dict = {

Check warning on line 165 in src/zarr/core/dtype/npy/structured.py

View check run for this annotation

Codecov / codecov/patch

src/zarr/core/dtype/npy/structured.py#L165 

Added line #L165 was not covered by tests
"name": self._zarr_v3_name,
"configuration": {"fields": fields},
}
return cast("DTypeSpec_V3", base_dict)
raise ValueError(f"zarr_format must be 2 or 3, got {zarr_format}") # pragma: no cover

Expand Down