Skip to content

Fix type of v2 compressors #3232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 11, 2025
Merged

Fix type of v2 compressors #3232

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b330dbd
Fix type of v2 compressors
dstansby Jul 11, 2025
73dbeb8
Add bugfix entry
dstansby Jul 11, 2025
df9a2aa
Merge branch 'main' into v2-metadata-comp-type
d-v-b Jul 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions changes/3232.bugfix.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
Fix the type of ``ArrayV2Metadata.codec`` to constrain it to ``numcodecs.abc.Codec | None``.
Previously the type was more permissive, allowing objects that can be parsed into Codecs (e.g., the codec name).
The constructor of ``ArrayV2Metadata`` still allows the permissive input when creating new objects.
2 changes: 1 addition & 1 deletion src/zarr/core/metadata/v2.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ class ArrayV2Metadata(Metadata):
order: MemoryOrder = "C"
filters: tuple[numcodecs.abc.Codec, ...] | None = None
dimension_separator: Literal[".", "/"] = "."
compressor: CompressorLikev2
compressor: numcodecs.abc.Codec | None
attributes: dict[str, JSON] = field(default_factory=dict)
zarr_format: Literal[2] = field(init=False, default=2)

Expand Down