Skip to content

fix obstore type hints #3242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 14, 2025
Merged

fix obstore type hints #3242

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
69939e5
liberally add type:ignores to appease mypy
d-v-b Jul 14, 2025
bc46c69
ok remove the type:ignore statements
d-v-b Jul 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions src/zarr/storage/_obstore.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
from zarr.core.config import config

if TYPE_CHECKING:
from collections.abc import AsyncGenerator, Coroutine, Iterable
from collections.abc import AsyncGenerator, Coroutine, Iterable, Sequence
from typing import Any

from obstore import ListResult, ListStream, ObjectMeta, OffsetRange, SuffixRange
Expand Down Expand Up @@ -216,14 +216,14 @@ def list(self) -> AsyncGenerator[str, None]:
# docstring inherited
import obstore as obs

objects: ListStream[list[ObjectMeta]] = obs.list(self.store)
objects: ListStream[Sequence[ObjectMeta]] = obs.list(self.store)
return _transform_list(objects)

def list_prefix(self, prefix: str) -> AsyncGenerator[str, None]:
# docstring inherited
import obstore as obs

objects: ListStream[list[ObjectMeta]] = obs.list(self.store, prefix=prefix)
objects: ListStream[Sequence[ObjectMeta]] = obs.list(self.store, prefix=prefix)
return _transform_list(objects)

def list_dir(self, prefix: str) -> AsyncGenerator[str, None]:
Expand All @@ -235,7 +235,7 @@ def list_dir(self, prefix: str) -> AsyncGenerator[str, None]:


async def _transform_list(
list_stream: ListStream[list[ObjectMeta]],
list_stream: ListStream[Sequence[ObjectMeta]],
) -> AsyncGenerator[str, None]:
"""
Transform the result of list into an async generator of paths.
Expand All @@ -246,7 +246,8 @@ async def _transform_list(


async def _transform_list_dir(
list_result_coroutine: Coroutine[Any, Any, ListResult[list[ObjectMeta]]], prefix: str
list_result_coroutine: Coroutine[Any, Any, ListResult[Sequence[ObjectMeta]]],
prefix: str,
) -> AsyncGenerator[str, None]:
"""
Transform the result of list_with_delimiter into an async generator of paths.
Expand Down
Loading