Skip to content

don't test self-deletion in stateful tests #3243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 14, 2025
Merged

don't test self-deletion in stateful tests #3243

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
aed9253
don't test self-deletion
d-v-b Jul 14, 2025
29d5329
don't alias
d-v-b Jul 14, 2025
724e3c9
add explanatory comment
d-v-b Jul 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/zarr/testing/stateful.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,9 +343,10 @@ def delete_array_using_del(self, data: DataObject) -> None:
@precondition(lambda self: len(self.all_groups) >= 2) # fixme don't delete root
@rule(data=st.data())
def delete_group_using_del(self, data: DataObject) -> None:
group_path = data.draw(
st.sampled_from(sorted(self.all_groups)), label="Group deletion target"
)
# ensure that we don't include the root group in the list of member names that we try
# to delete
member_names = tuple(filter(lambda v: "/" in v, sorted(self.all_groups)))
group_path = data.draw(st.sampled_from(member_names), label="Group deletion target")
prefix, group_name = split_prefix_name(group_path)
note(f"Deleting group '{group_path=!r}', {prefix=!r}, {group_name=!r} using delete")
members = zarr.open_group(store=self.model, path=group_path).members(max_depth=None)
Expand Down
Loading