Set correct chunk shape when using shards #3246
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs release notes
|
Okay, I went further down the rabbit hole and this isn't the correct fix. |
|
yes i think the correct fix is to ensure that we iterate over the correct array regions, not changing the chunks / shards declaration |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes sure the chunk shape is the chunk shape, and not the shard shape. I'm not sure why the chunk shape was being set to the shard shape, but I am worried this is going to break things, or at least pulling on this might result in a bit of a mess 😬
This is the root cause of, and fixes #3221
TODO:
docs/user-guide/*.rstchanges/