Skip to content

Use in and or instead of multipleif's #3266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 17, 2025
Merged

Use in and or instead of multipleif's #3266

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
94f45e1
Use `in` and `or` instead of multiple `if`'s
DimitriPapadopoulos Jul 17, 2025
29f66e6
Merge branch 'main' into PYL-R1714
d-v-b Jul 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions src/zarr/core/dtype/npy/common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -384,9 +384,7 @@ def check_json_float_v2(data: JSON) -> TypeGuard[JSONFloatV2]:
Bool
True if the data is a float, False otherwise.
"""
if data == "NaN" or data == "Infinity" or data == "-Infinity":
return True
return isinstance(data, float | int)
return data in ("NaN", "Infinity", "-Infinity") or isinstance(data, float | int)


def check_json_float_v3(data: JSON) -> TypeGuard[JSONFloatV3]:
Expand Down
Loading